Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AccessControlOwnable #280

Open
wants to merge 48 commits into
base: time-types
Choose a base branch
from
Open

Add AccessControlOwnable #280

wants to merge 48 commits into from

Conversation

ItsNickBarry
Copy link
Member

Continuation of #228, which was erroneously closed by GitHub.

paradoux and others added 24 commits October 3, 2023 08:29
@paradoux
Added AccessControlDefaultAdminRules
bcb5960
@paradoux
Corrected comments
defc7e4
@paradoux
Refactor comment storage pointer
d62dc3a
@ItsNickBarry
Merge branch 'master' into paradoux-implement-access-control-extension
06b9068
@ItsNickBarry
update abi
7d09542
@ItsNickBarry
update version pragmas
8bd5919
@ItsNickBarry
Merge branch 'master' into paradoux-implement-access-control-extension
c0660bf
@ItsNickBarry
update pragma statements
25b3c4e
@ItsNickBarry
fix inheritance order
4a9ac8e
@ItsNickBarry
Merge branch 'consolidate-storage' into paradoux-implement-access-con…
0bd9d52 
…trol-extension
@ItsNickBarry
fix references to _AccessControl and _IAccessControl
aa24702
@ItsNickBarry
merge AccessControlDefaultAdminRulesStorage into AccessControlStorage…
bd9bc31 
…, use explicit storage slot
@ItsNickBarry
fix AccessControlDefaultAdminRules inheritance pattern
7f74102
@ItsNickBarry
remove AccessControlDefaultAdminRulesMock, update revert tests
0b475b5
@ItsNickBarry
move onlyRole modifiers calls to _AccessControlDefaultAdminRules func…
ccd81e6 
…tions
@ItsNickBarry
remove virtual keyword from AccessControlDefaultAdminRules functions
ca5652d
@ItsNickBarry
use $ for AccessControlDefaultAdminRules storage references
e09e06d
@ItsNickBarry
fix revert test
82477ed
@ItsNickBarry
clean up some function declarations
06ba9de
@ItsNickBarry
Merge branch 'no-git-abi' into paradoux-implement-access-control-exte…
fae3671 
…nsion
@ItsNickBarry
remove ABIs from git
efe2fc7
@ItsNickBarry
Merge branch 'master' into paradoux-implement-access-control-extension
9aa0e20
@ItsNickBarry
Merge branch 'msg-sender-trick' into access-control-admin
672204b
@ItsNickBarry
retrieve message sender from context
e28cbc6
@ItsNickBarry ItsNickBarry changed the base branch from master to msg-sender-trick March 19, 2025 06:10
Base automatically changed from msg-sender-trick to master March 29, 2025 03:59
@ItsNickBarry
Copy link
Member Author

ItsNickBarry commented Apr 5, 2025 •
edited
Loading

This contract is far too opinionated.

Need to do this:

  • Replace the admin rules with a simple Ownable integration, where owner is the admin and has control over all roles.
  • Add a SafeOwnableTimelock module to optionally replace the time-based admin rules.

@ItsNickBarry ItsNickBarry changed the title Add AccessControlDefaultAdminRules Add AccessControlOwnable Apr 5, 2025
@ItsNickBarry ItsNickBarry mentioned this pull request Apr 5, 2025
Merged
@ItsNickBarry ItsNickBarry marked this pull request as ready for review April 7, 2025 01:53
@ItsNickBarry ItsNickBarry changed the base branch from master to time-types April 7, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItsNickBarry @paradoux